resolve compile warnings and enhance naming

src/base-environments/youth_room/fairylights.tscn

@@ -17,7 +17,7 @@ extends Node3D
 
 @onready var wires:LineRenderer3D = $wires
 @onready var diodes:MultiMeshInstance3D = $diodes
-@export var seed:int = 42
+@export var rng_seed:int = 42
 var rng = RandomNumberGenerator.new()
 @export var size:float = 0.1:
 	set(new_size):
@@ -32,14 +32,13 @@ func _ready():
 	rebuild()
 
 func rebuild():
-	rng.seed = seed
+	rng.rng_seed = rng_seed
 	rng.state = 0
 	for child in wires.get_children(): child.free()
 	wires.points = light_array
 	diodes.multimesh.instance_count = light_array.size()
 	var meshBuffer:PackedFloat32Array
 	for point in light_array:
-		rng
 		var base:Basis = Basis(Vector3(rng.randf_range(-1, 1), rng.randf_range(-1, 1), rng.randf_range(-1, 1)).normalized(), rng.randf_range(0, PI*2))
 		base = base.scaled(Vector3(size, size, size))
 		meshBuffer.append_array([base.x.x, base.x.y, base.x.z, point.x, base.y.x, base.y.y, base.y.z, point.y, base.z.x, base.z.y, base.z.z, point.z])
@@ -56,21 +55,22 @@ albedo_texture = ExtResource("1_xsr58")
 normal_enabled = true
 normal_texture = ExtResource("1_p3lcj")
 
-[sub_resource type="ImmediateMesh" id="ImmediateMesh_lq63p"]
+[sub_resource type="ImmediateMesh" id="ImmediateMesh_30v5y"]
 
 [sub_resource type="MultiMesh" id="MultiMesh_ic3h7"]
 transform_format = 1
-instance_count = 2
+instance_count = 30
 mesh = ExtResource("4_qh8yy")
-buffer = PackedFloat32Array(0.0998169, 0.00482103, -0.00365424, 0, -0.00428558, 0.0989875, 0.0135316, 0, 0.0042696, -0.0133502, 0.0990128, 0, 0.0700075, -0.0358849, 0.0617351, 0, 0.0525334, 0.0844406, -0.0104897, 1, -0.0483653, 0.0397751, 0.0779663, 0)
+buffer = PackedFloat32Array(0.0998169, 0.00482103, -0.00365424, -0.545, -0.00428558, 0.0989875, 0.0135316, 0.915, 0.0042696, -0.0133502, 0.0990128, 1.035, 0.0700075, -0.0358849, 0.0617351, -0.47, 0.0525334, 0.0844406, -0.0104897, 0.855, -0.0483653, 0.0397751, 0.0779663, 0.905, 0.0042587, 0.0920312, -0.0388859, -0.44, -0.00571533, 0.0390819, 0.0918692, 0.871, 0.0997457, -0.00168997, 0.00692427, 0.78, 0.0219999, -0.0870806, -0.0439656, -0.385, 0.0800974, 0.041851, -0.0428124, 0.91, 0.0556813, -0.0257966, 0.0789565, 0.69, 0.0923335, 0.0288341, -0.0253597, -0.38, -0.0359662, 0.088075, -0.0308096, 0.995, 0.0134518, 0.0375685, 0.0916933, 0.595, 0.0410372, 0.0236122, 0.0880819, -0.39, -0.0818364, -0.0330796, 0.0469951, 0.925, 0.0402337, -0.0913685, 0.00574842, 0.465, 0.0963897, 0.0249758, -0.00923199, -0.364, -0.025153, 0.0967818, -0.000788714, 0.86, 0.0087379, 0.00308236, 0.0995698, 0.211, 0.0905162, -0.0353528, 0.0236008, -0.295, 0.00980512, 0.0713907, 0.0693341, 0.82, -0.0413604, -0.0604445, 0.0680866, 0.06, 0.0999699, -0.000440024, 0.00241425, -0.255, 0.00037743, 0.0999657, 0.0025912, 0.805, -0.00242483, -0.00258131, 0.0999373, -0.15, 0.0666952, -0.0744692, 0.00246829, -0.175, 0.0669796, 0.0613729, 0.0417982, 0.83, -0.0326417, -0.0262242, 0.090812, -0.355, 0.00827521, 0.0528018, -0.0845191, -0.135, 0.0951837, -0.0293119, -0.00899272, 0.955, -0.0295225, -0.0797043, -0.0526844, -0.515, 0.0983988, -0.0102168, 0.0146044, -0.025, 0.00642553, 0.0967642, 0.0244007, 0.78, -0.0166249, -0.0230716, 0.0958714, -0.615, -0.0341773, -0.0716575, -0.0608039, 0.115, 0.0144934, 0.059907, -0.078747, 0.63, 0.0928539, -0.0357262, -0.010089, -0.695, -0.0232891, -0.0711249, 0.066324, 0.245, 0.0795472, -0.0531651, -0.0290812, 0.555, 0.0559451, 0.0459861, 0.0689595, -0.745, -0.0599926, -0.0254553, -0.075848, 0.37, -0.0708402, 0.0609612, 0.0355725, 0.595, 0.0371828, 0.0750717, -0.0546048, -0.805, 0.0107775, 0.0912119, 0.0395505, 0.455, 0.0273445, -0.0409675, 0.0870284, 0.745, 0.0955831, 0.00143545, -0.0293567, -0.84, 0.0745873, 0.00700857, -0.0662391, 0.505, -0.0366242, 0.0873785, -0.0319947, 0.89, 0.0556363, 0.0481236, 0.0677401, -0.87, -0.0524777, -0.0408163, -0.0747002, 0.445, -0.0771795, -0.0142038, 0.0619805, 1.175, -0.0359084, 0.0901791, -0.024048, -0.87, 0.0652616, -0.0746751, 0.0128275, 0.26, -0.071962, -0.0663868, -0.0203536, 1.28, 0.0237149, 0.00405218, -0.0970628, -0.815, 0.0477617, -0.0860534, 0.0177096, 0.125, -0.0450234, -0.00666441, 0.089042, 1.35, -0.0754435, -0.0505014, -0.0419272, -0.8, 0.0526553, -0.07791, -0.0340215, -0.037, -0.0570784, -0.00274075, -0.0820643, 1.479, 0.0630038, 0.0626301, -0.0459129, -0.834, 0.0726285, 0.053708, 0.0429017, -0.2, -0.0349996, 0.0826095, -0.0441667, 1.601, -0.0591619, 0.0170622, 0.0787956, -0.851, 0.0581542, 0.0297762, -0.0757065, -0.359, -0.0464154, 0.0885717, -0.000817926, 1.769, 0.0668109, 0.0356151, 0.0653289, -0.85, 0.0875991, -0.0425381, 0.0227357, -0.5, 0.0336438, 0.0876653, 0.0343932, 1.949, -0.0345616, -0.022479, 0.0911054, -0.85, 0.0946831, -0.0299322, -0.0117972, -0.594, 0.0199689, 0.0259233, 0.0944946, 2.126, -0.0252261, -0.0918261, 0.0305222, -0.85, 0.0626413, -0.0766232, 0.0143161, -0.634, 0.0779479, 0.0616799, -0.0109416, 2.238, -0.000446323, 0.0180131, 0.0983633, -0.85, 0.0510754, -0.0397606, 0.076226, -0.634, -0.0155809, 0.0829139, 0.0536891, 2.035, -0.084549, -0.0392986, 0.0361536, -0.85, -0.055891, -0.072196, -0.0407913, -0.614, -0.0700671, 0.0148083, 0.0697948, 1.875, -0.0443486, 0.0675903, -0.0588622, -0.85, -0.0545317, 0.0517385, -0.0659501, -0.65, 0.0389976, 0.0853039, 0.0346761, 1.655, 0.0741989, -0.00680947, -0.0666945, -0.85, 0.0858331, 0.0430527, -0.0279131, -0.65, 0.0302511, -0.0864024, -0.040243, 1.475, -0.0414433, 0.0260978, -0.0871858, -0.87)
 
 [node name="fairylights" type="Node3D"]
 script = SubResource("GDScript_2caij")
 light_array = Array[Vector3]([Vector3(0, 0, 0), Vector3(0, 1, 0)])
+seed = 42
 
 [node name="wires" type="MeshInstance3D" parent="."]
 material_override = SubResource("StandardMaterial3D_5ca5e")
-mesh = SubResource("ImmediateMesh_lq63p")
+mesh = SubResource("ImmediateMesh_30v5y")
 script = ExtResource("2_javfj")
 points = Array[Vector3]([Vector3(0, 0, 0), Vector3(0, 1, 0)])
 start_thickness = 0.01

src/base-environments/youth_room/room_handle.gd

@@ -50,8 +50,9 @@ func _on_scene_finished(id: int, _repeat:bool):
 	save_game.mementos_complete &= 1 << id
 	save_room()
 
+#FIXME forgot to comment what this means, just marking it for removal
 var fixed := false
-func hotfix(discard):
+func hotfix(_discard):
 	print("meep")
 	if not fixed:
 		await get_tree().create_timer(0.1).timeout

src/base-environments/youth_room/scnees/scene_player.gd

@@ -16,9 +16,9 @@ var max_lines: float = 0
 			substring_sizes = []
 			if Engine.is_editor_hint():
 				TranslationServer.set_locale("en")
-			for str in array:
+			for string in array:
-				label.text += TranslationServer.translate(str).replace("[/p]", "[/p][p][font_size=8] [/font_size][/p]")
+				label.text += TranslationServer.translate(string).replace("[/p]", "[/p][p][font_size=8] [/font_size][/p]")
-				substring_sizes.append(TranslationServer.translate(str).replace("[/p]", ".").replace("[p]", "").length())
+				substring_sizes.append(TranslationServer.translate(string).replace("[/p]", ".").replace("[p]", "").length())
 			max_lines = float(label.get_line_count())
 
 @export var progress: float = 0:

src/base-environments/youth_room/youth_room.tscn

@@ -1937,7 +1937,7 @@ transparent_bg = true
 size = Vector2i(400, 350)
 render_target_update_mode = 4
 
-[node name="CollectableUI" parent="logic/DoorTrigger/UiWrapper/UiSprite/SubViewport" instance=ExtResource("25_ghmim")]
+[node name="CollectableUi" parent="logic/DoorTrigger/UiWrapper/UiSprite/SubViewport" instance=ExtResource("25_ghmim")]
 
 [node name="HoverDetect" type="CollisionShape3D" parent="logic/DoorTrigger"]
 transform = Transform3D(-4.37114e-08, -1, 0, 1, -4.37114e-08, 0, 0, 0, 1, 0, 0, 0)
@@ -2244,6 +2244,7 @@ omni_attenuation = 0.659754
 [node name="fairylights" parent="." instance=ExtResource("39_q6rov")]
 transform = Transform3D(1, 0, 0, 0, 1, 0, 0, 0, 1, 2.89212, 5.96046e-08, -0.143107)
 light_array = Array[Vector3]([Vector3(-0.545, 0.915, 1.035), Vector3(-0.47, 0.855, 0.905), Vector3(-0.44, 0.871, 0.78), Vector3(-0.385, 0.91, 0.69), Vector3(-0.38, 0.995, 0.595), Vector3(-0.39, 0.925, 0.465), Vector3(-0.364, 0.86, 0.211), Vector3(-0.295, 0.82, 0.06), Vector3(-0.255, 0.805, -0.15), Vector3(-0.175, 0.83, -0.355), Vector3(-0.135, 0.955, -0.515), Vector3(-0.025, 0.78, -0.615), Vector3(0.115, 0.63, -0.695), Vector3(0.245, 0.555, -0.745), Vector3(0.37, 0.595, -0.805), Vector3(0.455, 0.745, -0.84), Vector3(0.505, 0.89, -0.87), Vector3(0.445, 1.175, -0.87), Vector3(0.26, 1.28, -0.815), Vector3(0.125, 1.35, -0.8), Vector3(-0.037, 1.479, -0.834), Vector3(-0.2, 1.601, -0.851), Vector3(-0.359, 1.769, -0.85), Vector3(-0.5, 1.949, -0.85), Vector3(-0.594, 2.126, -0.85), Vector3(-0.634, 2.238, -0.85), Vector3(-0.634, 2.035, -0.85), Vector3(-0.614, 1.875, -0.85), Vector3(-0.65, 1.655, -0.85), Vector3(-0.65, 1.475, -0.87)])
+rng_seed = null
 
 [connection signal="ini_room" from="." to="logic/PlayerController" method="_on_ini_room"]
 [connection signal="ini_room" from="." to="logic/ScenePlayer" method="_on_ini_room"]

src/dev-util/click-trough-area.gd

@@ -3,13 +3,6 @@ extends Area3D
 @export var billboard = true
 @onready var sprite: Sprite3D = $UiSprite
 @onready var viewport: SubViewport = $UiSprite/SubViewport
-
-func _ready() -> void:
-	return
-	var viewport_tex := ViewportTexture.new()
-	viewport_tex.viewport_path = "SubViewport" #viewport.get_path()
-	print(viewport_tex.viewport_path)
-	sprite.texture = viewport_tex
 	
 
 func _process(_delta):

src/dev-util/savegame.gd

@@ -7,7 +7,7 @@ class_name SaveGame extends Resource
 @export var mementos_complete: int = 0
 @export var board_state: Dictionary = {}
 @export var thumbnail: Texture = preload("res://import/interface-elements/empty_save_slot.png")
-@export var last_saved: float = Time.get_unix_time_from_system()
+@export var last_saved: int = int(Time.get_unix_time_from_system())
 
 @export var is_save_file_valid: bool = false
 

src/logic-scenes/board/card-board.gd

@@ -41,7 +41,7 @@ var has_stage = false:
 
 @onready var dropzone = $HBoxContainer/dropzone
 var dropzone_size: Vector2
-@export var dropzone_padding = 100
+@export var dropzone_padding:int = 100
 @onready var sticky_note_container = $HBoxContainer/ScrollContainer/VBoxContainer
 @onready var board_of_devs = $"board of devs"
 @onready var current_context:int = NAVIGATE:
@@ -145,9 +145,6 @@ func populate_board(card_names: Array[String]):
 	
 	var all_new:Dictionary = board_of_devs.get_cards_by_name_array(card_names)
 	
-	var new_cards:Array = all_new["cards"]
-	var new_sticky_notes:Array = all_new["sticky_notes"]
-	
 	# spawning the cards and adding them to the dictionary
 	for new_card in all_new["cards"]:
 		add_card(new_card)

src/logic-scenes/board/card.gd

@@ -162,7 +162,7 @@ func _on_mouse_exited():
 	highlighted = false
 	is_mouse_entered = false
 
-func _on_input_event(viewport, event, shape_idx):
+func _on_input_event(_viewport, event, _shape_idx):
 	
 	if event is InputEventMouseMotion:
 		_move_card()

src/logic-scenes/board/sticky-note.gd

@@ -140,7 +140,7 @@ func _on_area_exit(card: Area2D):
 	elif card is StickyNote and is_sticky_note_in_panel():
 		attached_to.collapse_gap()
 
-func _on_input_event(viewport, event, shape_idx):
+func _on_input_event(_viewport, event, _shape_idx):
 	if event is InputEventMouseButton:
 		if (event.button_index == MOUSE_BUTTON_LEFT and event.pressed) or event.button_index == MOUSE_BUTTON_RIGHT:
 			if "handle_hover" in current_handle:

src/logic-scenes/collectable/new_collectable_ui.gd

@@ -31,7 +31,7 @@ class_name CollectableUi extends CenterContainer
 #			
 #		if collapse and has_stage: State.leave_stage(self)
 
-@export var scene: Scenes.id = 0:
+@export var scene: Scenes.id = Scenes.id.YOUTH_DRAEVEN:
 	set(id):
 		scene = id
 		if is_inside_tree() and not is_board:

src/logic-scenes/main menu/main_menu.gd

@@ -37,8 +37,8 @@ func _ready() -> void:
 	save_game_handle.picked.connect(_on_save_picked)
 	continue_button.visible = save_game_handle.get_most_recent_save().current_room != 0
 	continue_button.pressed.connect(func(): start_game.emit(save_game_handle.get_most_recent_save()))
-	new_game_button.pressed.connect(func(): save_game_handle.pick_slot(true))
+	new_game_button.pressed.connect(func(): save_game_handle.pick_save_slot(true))
-	load_game_button.pressed.connect(func(): save_game_handle.pick_slot(false))
+	load_game_button.pressed.connect(func(): save_game_handle.pick_save_slot(false))
 	settings_button.get_popup().index_pressed.connect(settings_popup.show_settings)
 	quit_button.pressed.connect(get_tree().quit)
 	

src/logic-scenes/main menu/pause_menu.gd

@@ -10,17 +10,11 @@ class_name PauseManu extends PanelContainer
 # Called when the node enters the scene tree for the first time.
 func _ready() -> void:
 	resume_button.pressed.connect(owner.toggle_pause_menu)
-	to_menu_button.pressed.connect(_process)
+	#to_menu_button.pressed.connect(_process)
 	to_desktop_button.pressed.connect(func(): get_tree().quit())
-	to_settings_button.pressed.connect(_process)
+	#to_settings_button.pressed.connect(_process)
 	helpline_button.pressed.connect(func(): OS.shell_open("https://findahelpline.com/"))
-	skip_story_button.pressed.connect(_process)
+	#skip_story_button.pressed.connect(_process)
-
-
-# Called every frame. 'delta' is the elapsed time since the previous frame.
-func _process(delta: float) -> void:
-	pass
-
 
 func _on_help_pressed():
 	OS.shell_open("https://findahelpline.com/")

src/logic-scenes/main menu/save_game_list.gd

@@ -16,7 +16,7 @@ var save_buttons: Array[SaveGameDisplay]
 		load_games()
 var scroll_container: ScrollContainer
 
-var create_new_game: bool = false
+var override_save_slot: bool = false
 
 func _ready() -> void:
 	#FIXME: stop this from creating countless save games!
@@ -57,7 +57,7 @@ func load_games():
 		new_button.pressed.connect(func(): _on_game_picked(i))
 
 func _on_game_picked(id: int):
-	if create_new_game:
+	if override_save_slot:
 		if saves[id].current_room == 0:
 			picked.emit(id)
 		else:
@@ -66,9 +66,10 @@ func _on_game_picked(id: int):
 	else:
 		picked.emit(id)
 
-func pick_slot(create_new_game: bool):
+# This function is called when the user us supposed to choose a slot to load or create a new game.
+func pick_save_slot(create_new_game: bool):
 	State.take_stage(self)
-	self.create_new_game = create_new_game
+	self.override_save_slot = create_new_game
 
 func get_most_recent_save() -> SaveGame:
 	var most_recent_time := 0.0

src/logic-scenes/startup/startup.tscn

@@ -109,8 +109,9 @@ script/source = "extends TabContainer
 
 var focus_list: Array
 
-@onready var disable_rendering = $\"physical Accessibility/Container2/margin2/show nav buttons\"
+#FIXME when accessability setting is implemented properly
-@onready var simplified_controls = $\"physical Accessibility/Container2/simplified controls\"
+@onready var disable_rendering = false
+@onready var simplified_controls = false
 
 func _ready():
 	for child in get_children():
@@ -292,6 +293,7 @@ size_flags_vertical = 4
 selected = 1
 item_count = 5
 popup/item_0/text = "messy handwriting"
+popup/item_0/id = 0
 popup/item_0/disabled = true
 popup/item_1/text = "easy handwriting"
 popup/item_1/id = 1
@@ -317,6 +319,7 @@ disabled = true
 selected = 1
 item_count = 3
 popup/item_0/text = "none"
+popup/item_0/id = 0
 popup/item_1/text = "spoken text"
 popup/item_1/id = 1
 popup/item_2/text = "closed captions"

src/main.gd

@@ -42,7 +42,7 @@ func _ready():
 	
 	get_tree().tree_process_mode_changed.connect(pause_mode_changed)
 
-func _process(delta: float) -> void:
+func _process(_delta: float) -> void:
 	if currently_loading_room != "":
 		if ResourceLoader.load_threaded_get_status(currently_loading_room) == 3:
 			current_room = ResourceLoader.load_threaded_get(youth_room_path).instantiate()